HID: intel-ish-hid: Fix kernel panic during warm reset

Overview

In the Linux kernel, the following vulnerability has been resolved:

HID: intel-ish-hid: Fix kernel panic during warm reset

During warm reset device->fw_client is set to NULL. If a bus driver is registered after this NULL setting and before new firmware clients are enumerated by ISHTP, kernel panic will result in the function ishtp_cl_bus_match(). This is because of reference to device->fw_client->props.protocol_name.

ISH firmware after getting successfully loaded, sends a warm reset notification to remove all clients from the bus and sets device->fw_client to NULL. Until kernel v5.15, all enabled ISHTP kernel module drivers were loaded right after any of the first ISHTP device was registered, regardless of whether it was a matched or an unmatched device. This resulted in all drivers getting registered much before the warm reset notification from ISH.

Starting kernel v5.16, this issue got exposed after the change was introduced to load only bus drivers for the respective matching devices. In this scenario, cros_ec_ishtp device and cros_ec_ishtp driver are registered after the warm reset device fw_client NULL setting. cros_ec_ishtp driver_register() triggers the callback to ishtp_cl_bus_match() to match ISHTP driver to the device and causes kernel panic in guid_equal() when dereferencing fw_client NULL pointer to get protocol_name.

Affected

• Linux >= 44e2a58cb8803e3e40eaf5708c4d15b4118913c4 < 6c8cc40c588f8080a164d88336b1490279e0f1da
• Linux >= 44e2a58cb8803e3e40eaf5708c4d15b4118913c4 < 45b9055a3a3ff6e8c08faad82ea36a8644a81587
• Linux >= 44e2a58cb8803e3e40eaf5708c4d15b4118913c4 < 38518593ec55e897abda4b4be77b2ec8ec4447d1
• Linux 5.16

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.