perf: Fix hang while freeing sigtrap event

Overview

In the Linux kernel, the following vulnerability has been resolved:

perf: Fix hang while freeing sigtrap event

Perf can hang while freeing a sigtrap event if a related deferred signal hadn't managed to be sent before the file got closed:

perf_event_overflow() task_work_add(perf_pending_task)

fput() task_work_add(____fput())

task_work_run() ____fput() perf_release() perf_event_release_kernel() _free_event() perf_pending_task_sync() task_work_cancel() -> FAILED rcuwait_wait_event()

Once task_work_run() is running, the list of pending callbacks is removed from the task_struct and from this point on task_work_cancel() can't remove any pending and not yet started work items, hence the task_work_cancel() failure and the hang on rcuwait_wait_event().

Task work could be changed to remove one work at a time, so a work running on the current task can always cancel a pending one, however the wait / wake design is still subject to inverted dependencies when remote targets are involved, as pictured by Oleg:

T1 T2

fd = perf_event_open(pid => T2->pid); fd = perf_event_open(pid => T1->pid); close(fd) close(fd) <IRQ> <IRQ> perf_event_overflow() perf_event_overflow() task_work_add(perf_pending_task) task_work_add(perf_pending_task) </IRQ> </IRQ> fput() fput() task_work_add(____fput()) task_work_add(____fput())

task_work_run()                                        task_work_run()
    ____fput()                                             ____fput()
        perf_release()                                         perf_release()
            perf_event_release_kernel()                            perf_event_release_kernel()
                _free_event()                                          _free_event()
                    perf_pending_task_sync()                               perf_pending_task_sync()
                        rcuwait_wait_event()                                   rcuwait_wait_event()

Therefore the only option left is to acquire the event reference count upon queueing the perf task work and release it from the task work, just like it was done before 3a5465418f5f ("perf: Fix event leak upon exec and file release") but without the leaks it fixed.

Some adjustments are necessary to make it work:

• A child event might dereference its parent upon freeing. Care must be taken to release the parent last.

• Some places assuming the event doesn't have any reference held and therefore can be freed right away must instead put the reference and let the reference counting to its job.

Affected

• Linux >= 104e258a004037bc7dba9f6085c71dad6af57ad4 < aae58a39ac4c63c3fa53536fb2504c9f1d0e1719
• Linux >= 3a5465418f5fd970e86a86c7f4075be262682840 < fa1827fa968c0674e9b6fca223fa9fb4da4493eb
• Linux >= 3a5465418f5fd970e86a86c7f4075be262682840 < 665b87b8f8b3aeb49083ef3b65c4953e7753fc12
• Linux >= 3a5465418f5fd970e86a86c7f4075be262682840 < 1267bd38f161c1a27d9b722de017027167a225a0
• Linux >= 3a5465418f5fd970e86a86c7f4075be262682840 < 56799bc035658738f362acec3e7647bb84e68933
• Linux 9ad46f1fef421d43cdab3a7d1744b2f43b54dae0
• Linux ed2c202dac55423a52d7e2290f2888bf08b8ee99
• Linux f34d8307a73a18de5320fcc6f40403146d061891
• Linux >= 6.6.44 < 6.6.160
• Linux >= 5.15.165 < 5.16
• Linux >= 6.1.103 < 6.2
• Linux >= 6.10.3 < 6.11
• Linux 6.11

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.