drm/i915/gem: Zero-initialize the eb.vma array in i915_gem_do_execbuffer

Overview

In the Linux kernel, the following vulnerability has been resolved:

drm/i915/gem: Zero-initialize the eb.vma array in i915_gem_do_execbuffer

Initialize the eb.vma array with values of 0 when the eb structure is first set up. In particular, this sets the eb->vma[i].vma pointers to NULL, simplifying cleanup and getting rid of the bug described below.

During the execution of eb_lookup_vmas(), the eb->vma array is successively filled up with struct eb_vma objects. This process includes calling eb_add_vma(), which might fail; however, even in the event of failure, eb->vma[i].vma is set for the currently processed buffer.

If eb_add_vma() fails, eb_lookup_vmas() returns with an error, which prompts a call to eb_release_vmas() to clean up the mess. Since eb_lookup_vmas() might fail during processing any (possibly not first) buffer, eb_release_vmas() checks whether a buffer's vma is NULL to know at what point did the lookup function fail.

In eb_lookup_vmas(), eb->vma[i].vma is set to NULL if either the helper function eb_lookup_vma() or eb_validate_vma() fails. eb->vma[i+1].vma is set to NULL in case i915_gem_object_userptr_submit_init() fails; the current one needs to be cleaned up by eb_release_vmas() at this point, so the next one is set. If eb_add_vma() fails, neither the current nor the next vma is set to NULL, which is a source of a NULL deref bug described in the issue linked in the Closes tag.

When entering eb_lookup_vmas(), the vma pointers are set to the slab poison value, instead of NULL. This doesn't matter for the actual lookup, since it gets overwritten anyway, however the eb_release_vmas() function only recognizes NULL as the stopping value, hence the pointers are being set to NULL as they go in case of intermediate failure. This patch changes the approach to filling them all with NULL at the start instead, rather than handling that manually during failure.

(cherry picked from commit 08889b706d4f0b8d2352b7ca29c2d8df4d0787cd)

Affected

• Linux >= 544460c33821b44c2f0c643121303c3dc3f66ef1 < 25d69e07770745992387c016613fd7ac8eaf9893
• Linux >= 544460c33821b44c2f0c643121303c3dc3f66ef1 < 0336188cc85d0eab8463bd1bbd4ded4e9602de8b
• Linux >= 544460c33821b44c2f0c643121303c3dc3f66ef1 < 24d55ac8e31d2f8197bfad71ffcb3bae21ed7117
• Linux >= 544460c33821b44c2f0c643121303c3dc3f66ef1 < 63f23aa2fbb823c8b15a29269fde220d227ce5b3
• Linux >= 544460c33821b44c2f0c643121303c3dc3f66ef1 < 4fe2bd195435e71c117983d87f278112c5ab364c
• Linux 5.16

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.