mptcp: pm: ADD_ADDR rtx: free sk if last

Overview

In the Linux kernel, the following vulnerability has been resolved:

mptcp: pm: ADD_ADDR rtx: free sk if last

When an ADD_ADDR is retransmitted, the sk is held in sk_reset_timer(), and released at the end.

If at that moment, it was the last reference being held, the sk would not be freed. sock_put() should then be called instead of __sock_put().

But that's not enough: if it is the last reference, sock_put() will call sk_free(), which will end up calling sk_stop_timer_sync() on the same timer, and waiting indefinitely to finish. So it is needed to mark that the timer is done at the end of the timer handler when it has not been rescheduled, not to call sk_stop_timer_sync() on "itself".

Affected

• Linux >= 00cfd77b9063dcdf3628a7087faba60de85a9cc8 < aa8cabde7e83bf96269ee47427dc9b59e3ed8e60
• Linux >= 00cfd77b9063dcdf3628a7087faba60de85a9cc8 < 1f26487e83e69462540bb1047139472957c913c6
• Linux >= 00cfd77b9063dcdf3628a7087faba60de85a9cc8 < 5da972efed3dc7599da6e2b5e8d906d1b7b1a728
• Linux >= 00cfd77b9063dcdf3628a7087faba60de85a9cc8 < 6a3af482188f6db4186d1605f64d911d7330abb3
• Linux >= 00cfd77b9063dcdf3628a7087faba60de85a9cc8 < 531c537b8fb620beabccfb1594e8d43cbebbb87a
• Linux >= 00cfd77b9063dcdf3628a7087faba60de85a9cc8 < b74ad20198652b6b39a761c277ba65ae82b1e107
• Linux >= 00cfd77b9063dcdf3628a7087faba60de85a9cc8 < 8143a224785ceaf2b0856e08d4498916f38228fb
• Linux >= 00cfd77b9063dcdf3628a7087faba60de85a9cc8 < b7b9a461569734d33d3259d58d2507adfac107ed
• Linux 5.10

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.