l2tp: pppol2tp: hold reference to session in pppol2tp_ioctl()

Overview

In the Linux kernel, the following vulnerability has been resolved:

l2tp: pppol2tp: hold reference to session in pppol2tp_ioctl()

pppol2tp_ioctl() read sock->sk->sk_user_data directly without any locks or reference counting. If a controllable sleep was induced during copy_from_user() (e.g. via a userfaultfd page fault sleep), a concurrent socket close could trigger pppol2tp_session_close() asynchronously. This frees the l2tp_session structure via the l2tp_session_del_work workqueue. Upon resuming, the ioctl thread dereferences the stale session pointer, resulting in a Use-After-Free (UAF).

Fix this by securely fetching the session reference using the RCU-safe, refcounted helper pppol2tp_sock_to_session(sk) on entry. This locks the session's refcount across the sleep. We structured the function to exit via standard err breaks, guaranteeing that l2tp_session_put() is cleanly called on all return paths to drop the reference.

To preserve existing behavior we validate the session and its magic signature only for the specific L2TP commands that require it. This ensures that generic/unknown ioctls called on an unconnected socket still return -ENOIOCTLCMD and correctly fall back to generic handlers (e.g. in sock_do_ioctl()).

Affected

• Linux >= fd558d186df2c13a22455373858bae634a4795af < 312ecea13b67797747eb9d4b9dab8d3846de6dfb
• Linux >= fd558d186df2c13a22455373858bae634a4795af < 78cdfdca88cbf731a92f3b9ee5427c633dd94e28
• Linux >= fd558d186df2c13a22455373858bae634a4795af < e251d4cdfc725c9e7d686161e3b775a0e7d95053
• Linux >= fd558d186df2c13a22455373858bae634a4795af < 62f327e287cf7b595ae3f73ba72f5cd2a9e9f39f
• Linux >= fd558d186df2c13a22455373858bae634a4795af < a213a8950414c684999dcf03edeea6c46ede172e
• Linux 2.6.35

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.