KVM: Don't WARN if memory is dirtied without a vCPU when the VM is dying

Overview

In the Linux kernel, the following vulnerability has been resolved:

KVM: Don't WARN if memory is dirtied without a vCPU when the VM is dying

When marking a page dirty, complain about not having a running/loaded vCPU if and only if the VM is still alive, i.e. its refcount is non-zero. This will allow fixing a memory leak for x86 SEV-ES guests without hitting what is effectively a false positive on the WARN.

For some SEV-ES VM-Exits, KVM keeps a writable mapping of a guest page across an exit to userspace, and typically unmaps the page on the next KVM_RUN. But if userspace never calls KVM_RUN after such an exit, then KVM needs to unmap the page when the vCPU is destroyed, which in turn triggers the WARN about not having a running vCPU.

Alternatively, SEV-ES could temporarily load the vCPU to suppress the WARN, as is done in nested_vmx_free_vcpu() (but for completely unrelated reasons; suppressing WARN from nested_put_vmcs12_pages() is pure happenstance). But loading a vCPU during destruction is gross (ideally nVMX code would be cleaned up), risks complicating the SEV-ES code (KVM would need to ensure the temporarily load()+put() only runs when the vCPU isn't already loaded), and is ultimately pointless.

The motivation for the WARN is to guard against KVM dirtying guest memory without pushing the corresponding GFN to the active vCPU's dirty ring, e.g. to ensure userspace doesn't miss a dirty page. But for the VM's refcount to reach zero, there can't be any userspace mappings to the dirty ring, as mapping the dirty ring requires doing mmap() on the vCPU FD. I.e. if userspace had a valid mapping for the dirty ring, then the vCPU file and thus the owning VM would still be alive. And so since userspace can't possibly reach the dirty ring, whether or not KVM technically "misses" a push to the dirty ring is irrelevant.

Affected

• Linux >= 2efd61a608b0039911924d2e5d7028eb37496e85 < 21b880f040bd0e8b50ff30c5a40db7bf3384ff48
• Linux >= 2efd61a608b0039911924d2e5d7028eb37496e85 < 033d39e41fc30f484f4e4f37fb4cd76b12cbb18e
• Linux >= 2efd61a608b0039911924d2e5d7028eb37496e85 < 66a8e7ddd901023c89a2733494d827eca3f9c1b0
• Linux >= 2efd61a608b0039911924d2e5d7028eb37496e85 < 343e95c8ecc40e0738975ef4ee24c0c35e800e6b
• Linux >= 2efd61a608b0039911924d2e5d7028eb37496e85 < 99d7d43784ae3235026581e9bf892c036e04c8e6
• Linux >= 2efd61a608b0039911924d2e5d7028eb37496e85 < 8618004d3e897c0f1b71d9a9ab860461289bb89a
• Linux 5.17

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.