net/handshake: Use spin_lock_bh for hn_lock

Overview

In the Linux kernel, the following vulnerability has been resolved:

net/handshake: Use spin_lock_bh for hn_lock

nvmet_tcp_state_change(), a socket callback that runs in BH context, can reach handshake_req_cancel() via nvmet_tcp_schedule_release_queue() and tls_handshake_cancel(). handshake_req_cancel() acquires hn->hn_lock with plain spin_lock(). If a process-context thread on the same CPU holds hn->hn_lock when a softirq invokes the cancel path, the lock attempt deadlocks. This is the only caller that invokes tls_handshake_cancel() from BH context; every other consumer calls it from process context.

Deferring the cancel to process context in the NVMe target is not straightforward: nvmet_tcp_schedule_release_queue() must call tls_handshake_cancel() atomically with its state transition to DISCONNECTING. If the cancel were deferred, the handshake completion callback could fire in the window before the cancel runs, observe the unexpected state, and return without dropping its kref on the queue. Reworking that interlock is considerably more invasive than hardening the handshake lock. Convert all hn->hn_lock acquisitions from spin_lock/spin_unlock to spin_lock_bh/spin_unlock_bh so the lock is never taken with softirqs enabled.

Affected

• Linux >= 675b453e024154dd547921c6e6d5b58747ba7e0e < 06ab5978866fc2221b910347fd3e510ca8e7b1a4
• Linux >= 675b453e024154dd547921c6e6d5b58747ba7e0e < 0866569fc36a56f568acd3900d354e3505932e09
• Linux >= 675b453e024154dd547921c6e6d5b58747ba7e0e < 91898de9501a047ba67c6b864dcd403e00bdfbf5
• Linux >= 675b453e024154dd547921c6e6d5b58747ba7e0e < cc993e0927ec8bd98ea33377ada03295fcda0f24
• Linux 6.7

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.