thunderbolt: Prevent XDomain delayed work use-after-free on disconnect

Overview

In the Linux kernel, the following vulnerability has been resolved:

thunderbolt: Prevent XDomain delayed work use-after-free on disconnect

tb_xdp_handle_request() runs on system_wq and queues xd->state_work via queue_delayed_work() in three request handlers: PROPERTIES_CHANGED_REQUEST, UUID_REQUEST (via start_handshake), and LINK_STATE_CHANGE_REQUEST. Similarly, update_xdomain() queues xd->properties_changed_work when local properties change.

Concurrently, tb_xdomain_remove() calls stop_handshake() which does cancel_delayed_work_sync() on both delayed works. Later, tb_xdomain_unregister() calls device_unregister() which eventually frees the xdomain. Since commit 559c1e1e0134 ("thunderbolt: Run tb_xdp_handle_request() in system workqueue") moved the request handler off tb->wq, the handler and the remove path are no longer serialized. If queue_delayed_work() executes after cancel_delayed_work_sync() but before the xdomain is freed, the delayed work fires on a freed object.

Add xd->removing that tb_xdomain_remove() sets under xd->lock before calling stop_handshake(). Each external queue site holds the same lock and checks removing before calling queue_delayed_work(). This provides the mutual exclusion needed: either the queue site acquires the lock first and queues work that the subsequent cancel will see, or the remove path acquires the lock first and the queue site observes removing == true and skips the queue.

Affected

• Linux >= 559c1e1e013437bf190469efbcbd8bc803285853 < d4fa0d544c04dea636bf821ff5582cd7d63e2c34
• Linux >= 559c1e1e013437bf190469efbcbd8bc803285853 < cfbd2dba3d862c9be8c92bea2a357d9ed828a54a
• Linux >= 559c1e1e013437bf190469efbcbd8bc803285853 < dc11d5118f9da6ea28487ffe055de5a0d0734125
• Linux >= 559c1e1e013437bf190469efbcbd8bc803285853 < 91b40862a02000f490b63f1d315be3ee31e83871
• Linux >= 559c1e1e013437bf190469efbcbd8bc803285853 < 33c0ee18cf8665c974b00f4e0ba769fbc07efe10
• Linux >= 559c1e1e013437bf190469efbcbd8bc803285853 < 54a62153c765cd24239cde1f2633f2a2fd005368
• Linux >= 559c1e1e013437bf190469efbcbd8bc803285853 < 2aa2cde2cc79a79d8ea4a15be9f4a67fc528ae91
• Linux >= 559c1e1e013437bf190469efbcbd8bc803285853 < 2c5d2d3c3f70cde2565d7b279b544893a2035842
• Linux 5.2

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.