readdir: take no inode lock on an immutable directory

Overview

In the Linux kernel, the following vulnerability has been resolved:

readdir: take no inode lock on an immutable directory

iterate_dir() takes the directory's i_rwsem shared and holds it across ->iterate_shared(). For a directory that never has an entry and is never removed the lock keeps nothing still, it only orders every reader and every writer of that inode behind each other.

For the directory of a nullfs instance that matters. The instance of the initial mount namespace is the root of every empty mount namespace and the private instance is the root of every kernel thread, so one inode is shared across users who have nothing else in common. And a reader can hold the lock for as long as it likes: back the getdents() buffer with a mapping of a file on a FUSE mount of your own, let the copy of "." and ".." fault and let the server wait. Queue an exclusive taker behind it, a mkdir() in that directory goes through start_dirop() before the read-only mount is reported, and from then on every lookup that misses the dcache in that directory, every create and every mount on it waits until the server answers. One user of an empty mount namespace stalls all the others.

Add FOP_IMMUTABLE for the file operations of a directory that never changes and is never removed and let iterate_dir() skip the lock for it. The flag never changes for a file, ->f_pos is protected by f_pos_lock since directories are FMODE_ATOMIC_POS, IS_DEADDIR can't be set on such a directory and neither touch_atime() nor fsnotify take i_rwsem. Set it on the nullfs directory. The placeholder directories of libfs never have an entry either but their owners remove them, so they keep the lock.

Affected

• Linux >= 9d4e752a24f740b31ca827bfab07010e4e7f34b0 < 6d30b399ae28e5166d62484f81ccaefde6fe7996
• Linux >= 9d4e752a24f740b31ca827bfab07010e4e7f34b0 < e08f57a7dcb83818c058e415988c23beb6c5a47f
• Linux 7.1

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.