drm/exec: don't immediately add prelocked obj to array of locked objs

Overview

In the Linux kernel, the following vulnerability has been resolved:

drm/exec: don't immediately add prelocked obj to array of locked objs

When a contention is detected the drm_exec object grabs a reference to the contended object, unlocks all other objects and pre-locks the contended one before anything else.

The problem is that it is possible that this pre-locked object was about to be destroyed and drm_exec is now holding the last reference to it.

So we never actually see this pre-locked object again to be explicitly locked and so also never reserve a slot for a dma_fence object on it.

Should the driver now use drm_exec_for_each_locked_object() to add a new fence to all locked objects we eventually see a warning or even a BUG_ON() to prevent random memory corruption.

Fix this by keeping the prelocked object out of the array of locked objs until it was explicitly mentioned by the driver again.

If the prelocked object is never mentioned again by the driver just unlock and drop the reference at the end of the locking loop.

Affected

• Linux >= 09593216bff15866f95c8ad406cb7fdcec1ee40a < 96d9996e5dbcfabed052c0d9377a382c95fed607
• Linux >= 09593216bff15866f95c8ad406cb7fdcec1ee40a < 7a10cd79c4d9a90334fece32fef3a8e5b1a9727b
• Linux >= 09593216bff15866f95c8ad406cb7fdcec1ee40a < 26401a4999f1596a515b2e704e7066ac09306488
• Linux 6.6

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.